Philip Niedertscheider
Philip Niedertscheider
I believe we should update the PR branch before continuing review
From Cocoa Sync 06/18:This doesn't need to be a breaking change, but we need to clearly state it in the Changelog that this affects release health. As `beforeSend` in the...
I did an investigation to understand what currently happens when `SentrySDK.addBreadcrumb(_:)` is used before the SDK is ready and **it actually returns early** because no options are available, not recording...
Jumping in here even though it is still in draft, what made you rewrite the file in Swift?
Rough ideas what could be the issue here, needs further investigation: - `DefaultViewRenderer` uses [`drawHierarchy(in:afterScreenUpdates:)`](https://developer.apple.com/documentation/uikit/uiview/drawhierarchy(in:afterscreenupdates:)) which is slower than [`snapshotview(afterscreenupdates:)`](https://developer.apple.com/documentation/uikit/uiview/snapshotview(afterscreenupdates:)) according to [documentation](https://developer.apple.com/documentation/uikit/uiview/drawhierarchy(in:afterscreenupdates:)#Discussion) - `DefaultViewRenderer` creates a graphics context, draws...
@krystofwoldrich I understand your approach, most of UIKit's `UIView` use Core Animation's `CALayer` in the background, but AFAIK views (especially non-public SwiftUI helper views) can also directly render to the...
Quick update: I have performed an extensive benchmark and analyzed potential improvement strategies in #4940. We'll discuss how to use the learnings and my proposed changes.
We released two new options with [v8.47.0](https://github.com/getsentry/sentry-cocoa/releases/tag/8.47.0) (and will update the documentation shortly): - [`options.sessionReplay.enableExperimentalViewRenderer`](https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift#L109-L120) to enable the experimental view renderer which should reduce frame drops significantly. This is in...
@harrisrobin the options for React Native are not yet released but you can follow along this PR: https://github.com/getsentry/sentry-react-native/pull/4660
Hi @AlirezaHadjar, I would highly appreciate the repro! If you do not want to post it publicly, feel free to send it to [email protected] instead. > EDIT: this only happens...