Exceptions from `_crashOnException` should be fatal

Open itaybre opened this issue 6 months ago • 2 comments

Description

NSExceptions captured with _crashOnException should be marked as fatal as indicated by @philipphofmann at https://github.com/getsentry/sentry-cocoa/pull/5306/files#r2115252862

Jun 02 '25 21:06 itaybre

We should also consider marking sessions as crashed for events stemming from _crashOnException and ensure that enablePersistingTracesWhenCrashing works with _crashOnException.

Jun 03 '25 13:06 philipphofmann

From Cocoa Sync 06/18:

This doesn't need to be a breaking change, but we need to clearly state it in the Changelog that this affects release health. As beforeSend in the client is called after the session is marked as crashed in the hub.

Jun 18 '25 12:06 philprime