Results 6 comments of Phil Nichol

Can this be merged? This looks extremely helpful :)

same here, this feature would be really useful for us, any updates?

@tao12345666333 @iamNoah1 I'm happy to pick this up if you like? Would an acceptable solution be to add some validation in `_helpers.tpl` so that if `controller.service.enabled`, `"ingress-nginx.controller.fullname"` must be shorter...

@aryan9600 thanks for your time and response. From what I understand the finalizer logic only gets called if `RevertOnDeletion == true` and we are deleting the `canary` object. Flagger will...

@vatangbokade the maintainers will have a better answer, but most people probably don't need it, Flagger is awesome and works really well without it. IIRC we found in our testing...

@longwuyuan @rikatz @strongjz sorry to tag but any chance this PR got missed during the change freeze? It does indeed fix a real issue and would be really cool to...