terraforming icon indicating copy to clipboard operation
terraforming copied to clipboard

Improve s3

Open alexdotsh opened this issue 5 years ago • 2 comments

This is an addition to the original work that was done by sergeylanzman - [PR] here (https://github.com/dtan4/terraforming/pull/396)

I've only added the tests that was necessary to cover the changes in the code.

  • [x] Fix tests

alexdotsh avatar Jun 29 '19 19:06 alexdotsh

Coverage Status

Coverage remained the same at 100.0% when pulling e5556b6e3b15171511f70f546fc7a513e015cf2e on alexmirkhaydarov:improve-s3 into 67cb9299f283bc16bd70c197f25edc419bee280f on dtan4:master.

coveralls avatar Jun 29 '19 19:06 coveralls

Can this be merged? This looks extremely helpful :)

philnichol avatar Nov 27 '19 13:11 philnichol