Brandon Philips

Results 133 comments of Brandon Philips

_From @wking on June 21, 2016 4:0_ And the problem is (not surprisingly, given the error message) with `http/FileSystem` (see discussion in #150). The tests pass with the following patch:...

_From @wking on June 21, 2016 4:13_ Rolling back assorted dependencies, the issue was introduced by xeipuuv/gojsonschema#103, and there are already comments there about broken loading as a result. So...

_From @vbatts on June 21, 2016 14:10_ correct. rolling back https://github.com/xeipuuv/gojsonschema/commit/ac948b64b57aa1beeb91c87069730e6f24bc91d9 lets the tests pass again. :-\

_From @petemoore on June 21, 2016 17:43_ I think https://github.com/xeipuuv/gojsonschema/pull/105 fixed a bug introduced in https://github.com/xeipuuv/gojsonschema/pull/103 - so you _might_ not need to pin anymore...

_From @vbatts on June 21, 2016 17:45_ nope. 105 did not fix the issue. On Tue, Jun 21, 2016 at 1:43 PM, Pete Moore [email protected] wrote: > I think xeipuuv/gojsonschema#105...

_From @s-urbaniak on September 9, 2016 9:15_ logrus is pretty accepted in the ecosystem, and structured logging doesn't sound too bad. So I am +1 for this. On Fri, Sep...

_From @xiekeyang on September 9, 2016 10:1_ +1

_From @runcom on September 9, 2016 10:4_ I'll work on this once we reach consensus and figure out all the other issues about errors/warnings when validating an image, I would...

_From @xiekeyang on September 9, 2016 10:16_ It is deep related to #234 In which we are also discussing logrus. https://github.com/opencontainers/image-spec/pull/234#issuecomment-245789721

_From @s-urbaniak on September 9, 2016 10:25_ xfref regarding "how to inject the logger": https://github.com/opencontainers/image-spec/pull/234#issuecomment-245876579 I am in favor of classical dependency injection as per https://peter.bourgon.org/go-best-practices-2016/#program-design.