Brandon Philips

Results 133 comments of Brandon Philips

@wking exposed ports is useful metadata from the image. I think it needs to exist to retain useful UX from builder to runner. I am really really unclear on what...

_From @wking on May 25, 2016 15:44_ On Wed, May 25, 2016 at 08:22:16AM -0700, Brandon Philips wrote: > @wking exposed ports is useful metadata from the image. I think...

@wking the runtime can IGNORE this information and it can be used by a higher level system. I will file an issue about _how_ to convert it but I don't...

@wking I disagree with your suggestion of the split. The image format needs a way of expressing runtime defaults that aren't host specific which the runtime spec has not tackled...

_From @wking on May 25, 2016 20:21_ On Wed, May 25, 2016 at 09:11:49AM -0700, Brandon Philips wrote: > the runtime can IGNORE this information and it can be used...

I think what we should do is just have an annotation on the runtime spec config that lists the exposed ports. Something like: ``` { "ociVersion": "0.2.0", ... "annotations": {...

_From @wking on June 7, 2016 16:57_ On Mon, Jun 06, 2016 at 10:50:41PM -0700, Brandon Philips wrote: > I think what we should do is just have an annotation...

To what end do we add stuff to the runtime config.json though? We could simply say that the original manifest sits inside the bundle instead. The reason this annotation is...

_From @wking on June 7, 2016 23:45_ On Tue, Jun 07, 2016 at 04:40:25PM -0700, Brandon Philips wrote: > To what end do we add stuff to the runtime config.json...

@wking fair point. I think the runtime spec maintainers should chime in on this point of external files vs serialized metadata into the config.json.