Philipp Otto

Results 231 comments of Philipp Otto

I agree, that `0` should be a valid value for an empty segmentation layer (even though, it will be rare). However, what would be the semantics when the largest segment...

Since this is basically what I also suggested above, I'm all for it :smile:

This issue was also raised here https://scm.slack.com/archives/CBV2Q463E/p1646740212625469?thread_ts=1645796254.830969&cid=CBV2Q463E

Raised again: https://scm.slack.com/archives/CBV2Q463E/p1656494426639979?thread_ts=1656489350.964839&cid=CBV2Q463E Maybe we could use https://github.com/niklasvh/html2canvas to screenshot the scalebars and then overlay these with the other screenshots. Alternatively, I only see the option of rendering the scalebar...

> @philippotto Would you be interested in implementing the front-end todos here? Yes, I think, I can do that. Not sure when exactly I'll get to it, though :see_no_evil:

> @philippotto I changed the proto file to allow None for largestSegmentIds. Note that in the update actions they are still not nullable. Can we make the property in the...

> I was still assuming that volume annotating was essentially impossible while no largestSegmentId exists. But from what you mentioned in the meeting, it sounds like you want to only...

I think the front-end is ready for review. @fm3 Do you think the back-end is ready, too? Feel free to test the frontend behavior now :) If you agree with...

> However, I’d suggest that we explain to the user a bit more what is happening, or guide them towards a safe path. I guess the standard use case is...

> In case of an existing fallback layer, the latter is harmless, as the elementClass of the fallback layer is always used. But if there is no fallback layer, the...