Philipp Hofmann

Results 178 issues of Philipp Hofmann

### Description Our codebase uses [strncpy](https://github.com/search?q=repo%3Agetsentry%2Fsentry-cocoa+strncpy&type=code), which is unsafe according to the [Apple Secure Coding Guide](https://developer.apple.com/library/archive/documentation/Security/Conceptual/SecureCodingGuide/Articles/BufferOverflows.html#//apple_ref/doc/uid/TP40002577-SW1). We should replace it with `strlcpy`. Worth investigating if KSCrash has already fixed this....

Platform: Cocoa

### Description Currently, you can't add manual app start spans to the app start transaction directly after you call `SentrySDK.start`, because the app start transaction starts when the OS initializes...

Platform: Cocoa
Breaking-change

### Description Our app hang logic detects app hangs that don't fully block the main thread, which leads to inaccurate stack traces for such app hang events because the app...

Platform: Cocoa

`enumerateBacktracesForAllThreads` uses `ThreadHandle::allExcludingCurrent()` for building backtraces and suspends all threads except the current one. https://github.com/getsentry/sentry-cocoa/blob/06548c0f88eefd4a54851752c7d33f4270e34ba9/Sources/Sentry/SentryBacktrace.cpp#L102-L105 This code also suspends the mach threads of SentryCrash, which are not suspended when SentryCrash...

Platform: Cocoa
Component: Profiling

### Description Some users have some advanced use cases. They'd like to attach frequently changing information to crashes, but they can't add this info to the scope, cause it causes...

Improvement
Cocoa

### Description Add a `beforeSendTransactions` callback to the Options, as we have it for [Java](https://github.com/getsentry/sentry-java/blob/c9ca2e26898f7a44705e1a5033e48d657cb59ab1/sentry/src/main/java/io/sentry/SentryOptions.java#L709-L717). Although, transactions go through beforeSend, we plan on reverting this behavior in the next major...

Improvement
Cocoa

### Description A customer reported that their security vulnerability tool reported our repository has the following security issue: [CWE-676](https://cwe.mitre.org/data/definitions/676.html), which stands for the use of potentially dangerous functions. For all...

Improvement
Cocoa

### Description Before https://github.com/getsentry/sentry-cocoa/pull/2523, the SentryClient attached out-of-date context data to crashes. Instead of attaching the data in the SentryClient, we should put that data in the scope of the...

Type: Bug
Platform: Cocoa

### Description With https://github.com/getsentry/sentry-react-native/pull/3487 shipped in [5.12.2](https://github.com/getsentry/sentry-react-native/releases/tag/5.15.2) the SDK stopped sending navigation route params for auto-generated transactions because they could contain PII or other sensitive data. Instead of dropping all...

Platform: React-Native

See https://github.com/getsentry/sentry-cocoa/issues/1606