App, Culture Context for Crashes

Open philipphofmann opened this issue 3 years ago • 1 comments

Description

Before https://github.com/getsentry/sentry-cocoa/pull/2523, the SentryClient attached out-of-date context data to crashes. Instead of attaching the data in the SentryClient, we should put that data in the scope of the global hub, which automatically syncs the data to the scope of SentryCrash by using SentrySDK.currentHub configureScope.

The SDK already adds similar data to the scope in the SentryCrashIntegration, but this has the downside of having less context when disabling the SentryCrashIntegration. We could create an extra integration called SentryEventContextEnricher or something like that, and move the code form the SentryClient to this integration.

Dec 13 '22 09:12 philipphofmann

Here’s the original pr that attached the context: https://github.com/getsentry/sentry-cocoa/pull/2036

Dec 13 '22 17:12 armcknight

This was fixed with #3699.

Apr 30 '24 08:04 philipphofmann