sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Replace strncpy with strlcpy

Open philipphofmann opened this issue 2 years ago • 1 comments

Description

Our codebase uses strncpy, which is unsafe according to the Apple Secure Coding Guide. We should replace it with strlcpy. Worth investigating if KSCrash has already fixed this.

If we can simply replace strncpy with strlcpy, cause the code has test coverage we should do this quickly. If replacing is a bit complicated, needs refactoring to make things testable, we should reconsider the priority.

Related security issue: CWE-676.

philipphofmann avatar Mar 13 '23 10:03 philipphofmann

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Apr 06 '23 00:04 github-actions[bot]