Philipp Hofmann

Results 731 comments of Philipp Hofmann

On Cocoa, you have both `SentrySDK.currentHub`, which we use internally quite a lot, and `SentrySdk.setCurrentHub()`. I don't think that you have many use cases on mobile where you want to...

I think the main reason why this is public in Cocoa is that RN, for example, [uses it](https://github.com/getsentry/sentry-react-native/blob/8fc04313c4143ddd3ef6302d7ec08042924bf66d/ios/RNSentry.m#L149-L157). Still, we could replace the usages in RN with calls to a...

I agree with @marandaneto that we shouldn't expose `getCurrentHub`. It was public in Cocoa until 7.0.0. For me, it would be weird to do almost all interactions through the static...

This was fixed with https://github.com/getsentry/sentry-cocoa/pull/1021 in 2021. We can close this.

We're sampling at 100% now https://github.com/getsentry/sentry-options-automator/pull/1518. We can close this.

@ronyfadel, this could be fixed with https://github.com/getsentry/sentry-cocoa/pull/3458 released in [8.17.1](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8171). Can you try to update to this version and see if the problem persists?

We just released a new version of the Sentry Fastlane plugin [1.22.1](https://github.com/getsentry/sentry-fastlane-plugin/releases/tag/1.22.1) with Sentry CLI 2.31.2. Maybe worth giving this new version a shot.

@szokeasaurusrex, as sentry-fastlane-plugin version 1.22.1 with Sentry CLI 2.31.2 doesn't fix this issue, should we move it to the sentry-cli repository as you suggested in https://github.com/getsentry/sentry-cli/issues/2061?

@romtsn, @bitsandfoxes is on PTO and will be back on April 24th.

We should also consider marking sessions as crashed for events stemming from `_crashOnException` and ensure that `enablePersistingTracesWhenCrashing` works with `_crashOnException`.