sentry-unreal icon indicating copy to clipboard operation
sentry-unreal copied to clipboard

Alert filter unreal.crashtype not respected in alert rules

Open rodolfoBee opened this issue 2 years ago • 11 comments

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

1.Create a new alert with filter: The event's "unreal.crashtype" value "does not equal" "Ensure" so events that have this crash type do not trigger the alert. 2. Send an event to the project with unreal.crashtype=Ensure.

Example alert on test org: https://dev-curumas.sentry.io/alerts/rules/notjava/4430873/details/

Expected Result

Evens that contain Unreal.crash_type=Ensure in its additional context do NOT trigger the alert.

Actual Result

The alert is triggered.

At the start I suspected it was due to Minidump processing: the Unreal context is only added after applying DIFs to the event, but from what I see in the code, any event with the context should work.

So I sent a test event with a matching context (screenshot) and it triggered the alert. Screenshot 2023-04-11 at 09 39 21

Unreal filter option was recently added here: https://github.com/getsentry/sentry/pull/44021

In any case, this issue affects a paying customer, the specific information can be found in this internal ticket (not sharing due to possible PII). In the affected user's account there are unreal events with crash_type=Ensure that triggered the alert when the rule is set to trigger only when crash type is not equal to Ensure.

rodolfoBee avatar Apr 11 '23 07:04 rodolfoBee

Assigning to @getsentry/support for routing, due by (sfo). ⏲️

getsantry[bot] avatar Apr 11 '23 07:04 getsantry[bot]

Routing to @getsentry/issue-experience for triage, due by (sfo). ⏲️

getsantry[bot] avatar Apr 11 '23 07:04 getsantry[bot]

Routing to @getsentry/team-mobile for triage, due by (sfo). ⏲️

getsantry[bot] avatar Apr 11 '23 14:04 getsantry[bot]

Reassigning to the mobile team since this particular filter was added by them recently.

brianthi avatar Apr 11 '23 14:04 brianthi

@bitsandfoxes would you mind looking into this, since you've implemented the feature? thanks

romtsn avatar Apr 15 '23 08:04 romtsn

@romtsn, @bitsandfoxes is on PTO and will be back on April 24th.

philipphofmann avatar Apr 17 '23 11:04 philipphofmann

@rodolfoBee @romtsn On it.

bitsandfoxes avatar Apr 25 '23 10:04 bitsandfoxes

Started using Sentry's Unreal integration recently and I have been running into exact same issue. Support forwarded me link to this issue. Would love to see this resolved so that I can properly configure Sentry alerts to only be sent for crashes and asserts and not for ensures

suyashFSG avatar Jun 07 '23 18:06 suyashFSG

@suyashFSG Thanks for reaching out. Yes, we'll revisit this.

bitsandfoxes avatar Jun 08 '23 11:06 bitsandfoxes

Is there a still a plan to address this? I just ran into this issue and it's preventing me from configuring the alert setup that I want. Would love to see this fixed so that I don't have to use a subpar workaround.

wildlight-sam avatar May 17 '24 21:05 wildlight-sam

Thanks for bringing this back up. Sorry, I lost track of it and will update here accordingly.

bitsandfoxes avatar May 27 '24 12:05 bitsandfoxes

Well, it's been some time.

bitsandfoxes avatar Dec 12 '24 20:12 bitsandfoxes

Any plans on getting this fixed anytime soon? its been well over a year and half since it was originally reported

suyashFSG avatar Dec 12 '24 20:12 suyashFSG

Thank you for your patience. We'll prioritize revisiting this as soon as possible.

tustanivsky avatar Dec 13 '24 14:12 tustanivsky

I've been able to reproduce the behavior on my end. After some investigation it seems there might be an issue with the changes introduced in https://github.com/getsentry/sentry/pull/44021.

Specifically, while the attribute unreal.crashtype is defined here for creating alert rules the code appears to be checking against unreal.crash_type when filtering events.

@bitsandfoxes Could you confirm if this might be the case?

tustanivsky avatar Dec 27 '24 08:12 tustanivsky