pharo

pharo copied to clipboard

Review the welcome on the discord channel because it loos outdated.

Ducasse

[RB] safeMethodNameFor: aClass basedOn: aString could be covered by some tests.

1

In RBRefactoring.

Ducasse

[RB] Replace senders does not work from the code pane

1

We could not find a way to make ReplaceMessageSendTransformation (menu item (T) Replace senders to work because the context is different from the one we get when we click on...

Ducasse

And we should replace them with the `StRefactoringPreviewPresenter`

Ducasse

The first you use "doit" in the Playground it takes around 5 seconds

13

Seb showed me this today in P11

Ducasse

I verified and I found a bug - I have a class which uses a trait - I apply insert superclass - and my class does not have the trait...

Ducasse

[RB] RBRemoveAllSenders improvements: name is bad, semantics is fuzzy

1

- first it should renamed RBRemoveAllSelfSendTransformation because we can have no warrantee. - second the API is really strange: why passing a range and not just a selector (note that...

Ducasse

[RB] checkMethodName: aString in: aClass has an extra unused argument

1

``` checkMethodName: aString in: aClass "Return whether the argument aName is can represent a selector" "You probably look for checkMethodName: since the second argument is ignored" ^aString isString and: [...

Ducasse

In the following getNewSelector is actually doing a side effect so if we compute superclass preconditions and local one, they fail of course. ``` localPreconditions | imps | self getNewSelector....

Ducasse

It contains the following condition that we tagged as breaking changes but this is not that clear ``` (RBCondition withBlock: [ (class allSubclasses anySatisfy: [ :cls | cls definesInstanceVariable: temporaryVariableName...

Ducasse