pharo icon indicating copy to clipboard operation
pharo copied to clipboard

[RB] RBRemoveAllSenders improvements: name is bad, semantics is fuzzy

Open Ducasse opened this issue 2 years ago • 1 comments

  • first it should renamed RBRemoveAllSelfSendTransformation because we can have no warrantee.
  • second the API is really strange: why passing a range and not just a selector (note that the comment is mentioning the range but the api accepts selector).
  • third why only self sends?
  • The refactoring was actually checking that the result of the method is not stored. But this gives no behavior preservation since the method can actually modify the state of the object.
  • So this is clearly not a refactoring

Ducasse avatar Jun 05 '23 15:06 Ducasse

We should check first extractRefactoring in particular the extractMethodTransformation Then the inlineRefactoring and its transformation.

Ducasse avatar Jul 13 '23 17:07 Ducasse