[RB] safeMethodNameFor: aClass basedOn: aString could be covered by some tests.

[Ducasse]

In RBRefactoring.

[Ducasse]

still valid

[clacker]

I would like to take this one as my "First Issue" if that's OK.

[Ducasse]

Thanks a lot!

[Ducasse]

I think that the tests show that the logic of safeMethodNameFor:basedOn: is bogus. So this is good.

Because for binary selector it should not add the number at the end since these are not syntactically correct.

Here is what I would do. Either

check explicitly in safeMethodNameFor:basedOn: if the argument represents a binary selector (using isBinary) and in the case just return it. rename safeMethodNameFor:basedOn: into safeAccessorNameFor:basedOn: Update the corresponding test.