Pat Gunn

Results 238 comments of Pat Gunn

This is great; it'll be a good foundation for splitting into a new repo; I'm hoping we can do that after Manuel is done with his work.

Hello, Sorry for the long wait; I'm not sure whether this is enough to generally broaden the scope of 3d movies in the codebase. It'd help though, and it's not...

Actually, I'm not sure we should save the movie this way in the case of a 3d movie; it'd flatten it down in the memmap and I don't know if...

Hm. Actually, given that you've verified that at least some code paths downstream work with this, maybe it's best to accept it, not document it (outside of the code) for...

I've been looking at this again recently - this is with the offline algorithm? (also wondering if load_iter would help)

What's the name of the CNMF Parameter you're using that you're calling L1_ratio here?

I'm not finding this within the current codebase or a sampling of older versions of the codebase. Can you include a code snippet showing how you're setting this? It's possible...

Oh! I had not realised you were the same person who had asked for the parameter to be threaded through to sklearn's NMF function (had actually forgotten about that request...

Also, on that other request, we may eventually want to change a lot of how this works, but for now I think it probably makes sense to thread this parameter...

@DrDaheeJang I'm going to look at this in more detail now as we've added the l1_ratio configurability in the most recent release. Is your data something you might reasonably be...