Philipp Grete

Clang/Cuda/Debug build of unit tests not working

1

Using Clang (clang-12 and clang-13 confirmed) for target device Cuda with build type `Debug` fails with ``` [ 63%] Building CXX object tst/unit/CMakeFiles/unit_tests.dir/kokkos_abstraction.cpp.o In file included from :1: In file...

See https://github.com/parthenon-hpc-lab/parthenon/pull/879#discussion_r1223320539

Flowchart for tasks

3

At the Athena meeting (and also other discussions) it became clear that having a flow chart of the tasks is very useful. In principle this should be very straightforward by...

WIP: Fix compiler warnings

2

## PR Summary ## PR Checklist - [ ] Code passes cpplint - [ ] New features are documented. - [ ] Adds a test for any bugs fixed. Adds...

WIP: Fix single precision configuration

3

## PR Summary In theory we already supported single precision. In practice, it didn't work (not even compilation). Todos: - [ ] Add test coverage for single prec - [...

`CopyFluxCorrectionBufferSameProcess` does not seem to be used any more and should be removed. In the process, we should also double check that buffers on the same process are not copied...

WIP: Add AMR performance test

4

## PR Summary This test reflects the test case we used during the hackathon, i.e., 32^3 blocks with the following "evolution": ``` cycle=0 time=0.0000000000000000e+00 dt=8.7890624999999991e-04 zone-cycles/wsec_step=0.00e+00 wsec_total=5.54e-03 wsec_step=5.47e+00 zone-cycles/wsec=0.00e+00 wsec_AMR=0.00e+00...

WIP: more autoamted performance regression scipts

5

## PR Summary ## PR Checklist - [ ] Code passes cpplint - [ ] New features are documented. - [ ] Adds a test for any bugs fixed. Adds...

`ParArrays` not necessarily init to `0` for *A*MR sims

2

Our assumption that data in `ParArray#D`s is initialized to 0 does not hold for simulations with adaptive mesh refinement! That may lead to very subtle bugs in the initial conditions....

Here are a couple of items I noted when refactoring the docs: - [ ] AMR criteria incomplete/outdated - [ ] Hierarchy of headings in boundary communication potentially incorrect -...