Philipp Grete
Philipp Grete
Depending on the type of source (split/unsplit), we need to take special care of the content in the the `prim` and `cons` registers and their update (so that multiple split...
@BenWibking opened on GitLab https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/15: This method is described in: Rider, Greenough, and Kamm (JCP, Vol. 225, 2, p. 1827-1848): https://ui.adsabs.harvard.edu/abs/2007JCoPh.225.1827R/abstract. I tested this method in conjunction with RK2, but...
@BenWibking reported on https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/14: It would be very useful to implement the shock flattener from Miller & Colella (2002): https://ui.adsabs.harvard.edu/abs/2002JCoPh.183...26M/abstract Thread: > @pgrete FYI (not sure if you've seen it),...
Migrated from GitLab: https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/8: In the future, mbar might be the more generalizable parameter for defining the temperature. We could add it as an alternative to defining He_mass_fraction. However, since...
RK12/45, RKL2 (and potentially other) integrators currently in AthenaPK could be moved upstream to Parthenon.
From https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/2: The use is not consistent (sometimes `constexpr`, sometimes GetDim from parameter pack, sometimes duplicate hardcoded in specific function, e.g., pgen for hydro and mhd linear wave).
The adaptive and Townsend integrators do not require a limitation on the timestep a priori. Nevertheless, from a physical point of view it may be desired to limit the timestep...
Where does the data in the Schure cooling table actually come from, @forrestglines ? The comment say ``` # Cooling table for solar metallicity, 1/2 solar metallicity # (from Chris...
- Def of small num - PVRS in HLLE - add small num