Phil Jones comments

Repositories
Issues
Comments

Results 176 comments of


                                            Phil Jones

Lint Failure when using @route_cors

I don't have a good solution for this, see https://github.com/python/mypy/issues/16282

Adding the same route twice will silently fail, should raise an exception instead

#3038 is a potential fix - feedback welcome

url matching order changed versus 2.2

I don't think this is clear in Werkzeug < 2.2 as if you change your path to `/bar` from `/healthcheck` you will get the opposite result. This is due to...

url matching order changed versus 2.2

I think main thing to note is that the subdomain is checked before path parts and that static subdomain matches take precedence over dynamic matches. (Static path parts also take...

Add a DuplicatedRulesError

Yep, I should have used `_parts` as updated now.

Pydantic models are not valid Quart Response type

I don't think it is possible to type hint correctly yet, I think Concatenate needs kwarg support to do so.