Philip Feairheller comments

Results 61 comments of


                                            Philip Feairheller

Change storage and indexing for Next public Keys

Needed for Signify

running issue-xbrl-attestation.sh creates files/dirs in repo

I believe the 2 logs directories are created by unit tests not this shell script. Can you confirm that you ran unit tests before the script? You are correct about...

add workflow for publishing npm package

@lenkan The secret NPM_DEPLOY_SECRET has been created with WRITE access to signify-ts.

Change the name field in package.json to '@WebOfTrust/signify'

Suggestion from @m00sey to use `@keri` as the scope. @kentbull the sole dissenting vote

Change the name field in package.json to '@WebOfTrust/signify'

Yes, it is mine

Change the name field in package.json to '@WebOfTrust/signify'

Sure thing, I'll add you folks today.

Missing integration test coverage for holding revoked credential

Fixed with PR #225

signature-params component of signature-base is not serialized

This is not needed for EBA use cases. The current implementation is working fine. It is at most a nice to have.

signature-params component of signature-base is not serialized

> > This is not needed for EBA use cases. The current implementation is working fine. It is at most a nice to have. > > In terms of adoption,...

HTTP query params are not signed

I will add a link to the HTTP signature headers specification.