signify-ts icon indicating copy to clipboard operation
signify-ts copied to clipboard

Missing integration test coverage for holding revoked credential

Open lenkan opened this issue 1 year ago • 2 comments

Previously, we had these lines commented out in the credentials test: https://github.com/WebOfTrust/signify-ts/blob/2a95620742a5a28cb1d27468e13a1597b3cc08dd/examples/integration-scripts/credentials.test.ts#L311-L336.

We should introduce coverage for this feature again. However, just adding the same check does not work currently with new IPEX.

lenkan avatar Jan 06 '24 17:01 lenkan

Fixed with PR #225

pfeairheller avatar Feb 26 '24 04:02 pfeairheller

Fixed with PR #225

@pfeairheller It looks like #225 only includes the revocation itself and only involves the issuer? The issue above was about how the holder of a credential is made aware of a revocation.

Perhaps this should be closed anyway as a "working as intended". But I do think it would be good with an example of how a holder would be made aware that their credential revocation.

lenkan avatar Feb 26 '24 07:02 lenkan