running issue-xbrl-attestation.sh creates files/dirs in repo

[haroldcarr]

Using a2bab90 (development branch).

After running ./keripy/scripts/demo/vLEI/issue-xbrl-attestation.sh the following files/directories were created:

./keripy/credential.json
./keripy/src/keri/demo/logs
./keripy/src/keri/end/logs

It seems, after reading, ./keripy/scripts/demo/README.md, that these should probably be written to one of:

/tmp
/usr/local/var/keri
$HOME/.keri

[pfeairheller]

I believe the 2 logs directories are created by unit tests not this shell script. Can you confirm that you ran unit tests before the script?

You are correct about credential.json, it should be created in /tmp.

We would welcome a PR fixing this oversight in the script.

[haroldcarr]

you are right, the 2 log dirs show up after running

pytest tests/ --ignore tests/demo/
pytest tests/demo/

[kentbull]

So should this issue be closed? Creating files in the virtual environment folder doesn't seem too bad.