Peter Metz
Peter Metz
> > > Here we are generating the java client code and their corresponding artifacts, so > > > > > > 1. For the java client code, we can...
> > > > > Here we are generating the java client code and their corresponding artifacts, so > > > > > > > > > > 1. For...
> > @brunoffmateus Please squash the commits and fix the merge conflicts and make sure to rebase onto upstream main. > > Also, the PR currently looks HUGE so if...
> @petermetz @jagpreetsinghsasan I can take care of it if no one is on it right now. @rwat17 Works for me but I have one ask: Break it down to...
> @petermetz made a PR, there is quite a lot to check. Made separated commits as requested. @rwat17 I was asking to break it down to separate pull requests not...
@jagpreetsinghsasan Were your change requests addressed to your satisfaction?
> > @jagpreetsinghsasan Were your change requests addressed to your satisfaction? > > Yes @petermetz , I have resolved those review comments. Its good to merge @jagpreetsinghsasan Got it, thank...
> @petermetz Done, I've added the following to the commit: > > ``` > - This is not permanent - we'd love to bring the package back once the >...
@RafaelAPB Quick question: Is this specified on the spec level as well? E.g. does the spec say that these user-driven hook points need to be implemented? Just curious.
@RafaelAPB Do you happen to remember any context about this etherscan API key? I'm assuming these tests were passing originally but wondering how.