cacti icon indicating copy to clipboard operation
cacti copied to clipboard

feat(cactus-example-tcs-huawei): remove deprecated sample app

Open outSH opened this issue 1 year ago • 2 comments

  • cactus-example-tcs-huawei is using cactus-plugin-ledger-connector-go-ethereum-socketio and cactus-plugin-ledger-connector-tcs-huawei-socketio which will be removed as well. Ths sample app can't exist on it's own.

Closes #3157 Part of #3155

Pull Request Requirements

  • [x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

outSH avatar Mar 29 '24 11:03 outSH

@petermetz Done, I've added the following to the commit:

- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue https://github.com/hyperledger/cacti/issues/3155 on github for more details on context and reasoning
    of this decision.

outSH avatar Apr 02 '24 08:04 outSH

@petermetz Done, I've added the following to the commit:

- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue https://github.com/hyperledger/cacti/issues/3155 on github for more details on context and reasoning
    of this decision.

@outSH Looks good to me, thank you for adding the extra clarifications!

petermetz avatar Apr 05 '24 05:04 petermetz