cacti icon indicating copy to clipboard operation
cacti copied to clipboard

build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421

Open aldousalvarez opened this issue 1 year ago • 3 comments

Commit to be reviewed


build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421

Primary Changes
----------------
1. Updated the version of the base image that is used in the Dockerfile
2. Updated the Dockerfile to use the yarn version 3
3. Updated the README to the new command to run the container

Fixes #2745

Pull Request Requirements

  • [x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • [x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • [x] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

aldousalvarez avatar Jan 26 '24 10:01 aldousalvarez

Hello @jagpreetsinghsasan already fixed it, thank you. Updated it also with the commit message that Peter has mentioned

aldousalvarez avatar Mar 18 '24 11:03 aldousalvarez

LGTM

TheJagpreet avatar Apr 02 '24 07:04 TheJagpreet

@petermetz No worries, Already updated it and re requested for review. Thank you

aldousalvarez avatar Apr 08 '24 07:04 aldousalvarez

@jagpreetsinghsasan Were your change requests addressed to your satisfaction?

petermetz avatar Jun 26 '24 20:06 petermetz

@jagpreetsinghsasan Were your change requests addressed to your satisfaction?

Yes @petermetz , I have resolved those review comments. Its good to merge

TheJagpreet avatar Jun 27 '24 04:06 TheJagpreet

@jagpreetsinghsasan Were your change requests addressed to your satisfaction?

Yes @petermetz , I have resolved those review comments. Its good to merge

@jagpreetsinghsasan Got it, thank you for confirming! I'll dismiss the review then.

petermetz avatar Jul 01 '24 23:07 petermetz