Peter Goldstein

Results 61 comments of Peter Goldstein

Run on my fork - https://github.com/petergoldstein/fx/actions/runs/2503697575 @teoljungberg You may need to explicitly enable GitHub Actions on the repo. Sometimes that seems to be required, other times it turns on automatically.

@teoljungberg Not doing these changes all at once makes this harder. Essentially I would need to restructure the CI matrix multiple times. dealing with EOLd versions of Ruby and Rails...

Ok. That's fine. As a note, the proposed approach doesn't actually accomplish anything. This PR is a CI only change, so it doesn't break any Ruby or Rails versions that...

@teoljungberg What's required to do this? And what's the Rails / Ruby support policy for this gem? I'd like to add Rails 7 and Ruby 3.1, and that's a lot...

@teoljungberg Sure. A couple of related questions before I submit a PR: 1. What's the minimum Ruby version you want to support? 2.4, 2.5, and 2.6 (all in the `.travis.yml`...

Does anyone have a reproducible test case that we can add to the specs?

I think it should be possible, but I'm not entirely sure that implementing a [simple pipeline, as in `redis-rb`](https://github.com/redis/redis-rb#pipelining), is actually doable with `memcached`. My understanding of the `redis-rb` implementation...

Let me keep it open for now. I have some thoughts on how to do that refactoring, as well as how to deal with the ring. I can't look at...

@justinschier @esilverberg Sorry for the late reply. I'm getting a similar result, albeit with somewhat different numbers. When I run a test, I see repeated success with 60k keys, and...

So i think I have a handle on this. Basically it looks like memcached is behaving in an unexpected way, which is causing network issues because of how we're reading...