Peter Goldstein

Results 61 comments of Peter Goldstein

Since this is still open I've updated it so it includes: - Running Rails head and Ruby 2.7 in combination, since that's not supported - Ruby 3.2, which was released...

Required an rspec upgrade to get it to run green with Ruby 3.2. Now this PR runs green on my fork.

Since `cache_nils` is defined on the `Client` initializer, and `skip_nil` is defined on `fetch` they're not quite equivalent, but there should be a configuration that makes things work in a...

@andrepcg So this isn't quite right. Looking at `ActiveSupport::Cache::Store` you can see a few things: 1. `fetch`, and only `fetch`, supports the `skip_nil` option. [These are not supported on the...

So I'm getting a bundler segfault on Ruby 2.2, but everything else is green with no warnings. Not sure if you want to maintain support for 2.2 at this point.

@panthomakos For what it's worth, rerunning the 2.2 job on my fork caused it to pass.

Also worth noting that it runs green on my fork, including for 2.2 - https://github.com/petergoldstein/timezone/pull/1

This adds Ruby 3.2, fixes the GitHub Action config so we don't run into bundler issues related to Ruby 2.5/bundler 2.4 incompatibility, and fixes a few lints.

@nickcharlton I hadn't seen your branch. I'm getting similar, but not exactly the same failures. And unlike you, I don't have any jobs running green. I'm running everything on the...

You may want to: 1) Add Ruby 3.2 to the matrix 2) Update checkout actions to v3 to avoid Node 12 warnings and possible near term breakage