P Balance error with ECA not checked due to unassigned nstep variable

[peterdschwartz]

Issue discovered while trying to clean up EcosystemDyn initialization. In EcosystemBalanceCheckMod.F90, the routine ColPBalanceCheck never assigns the nstep variable (used here ). Proper assignment of nstep results in ERS.f19_g16.I1850CNECACTCBC.chrysalis_intel.elm-eca test to FAIL due to a P imbalance.

Error message:

108:  column pbalance error =   1.093868147954791E-008       59168
108:  Latdeg,Londeg=  -6.63157894736850        140.000000000000
108:  begpb       =   8.507429961268616E-002
108:  endpb       =   8.508126786597042E-002
108:  delta store =   6.968253284264647E-006
108:  input mass  =   6.946375921374247E-006
108:  output mass =  -3.281604436994799E-008
108:  net flux    =   6.979191965744195E-006
108:  ptol_pflux: =   1.729470039394304E-006
108:  sminp_to_plant: =   0.000000000000000E+000
108:  primp_to_labilep =   4.353013988347320E-013
108:  supplement_to_sminp =   0.000000000000000E+000
108:  secondp_to_occlp =   2.361073459870604E-024
108:  sminp_leached =  -3.281604436994799E-008
108:  ENDRUN:
108:  ERROR in EcosystemBalanceCheckMod.F90 at line 760

[peterdschwartz]

@bishtgautam I tested this with current master branch and inserting nstep = get_nstep() or similar to change causes the test to fail

[ndkeen]

Peter noted I found same issue and didn't see this, so adding what I found here:

With Jan23 master and ERS_D.f19_g16.I1850CNECACTCBC.pm-cpu_intel.elm-eca:

Same error with SMS_D_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.pm-cpu_intel.elm-fan and be related to https://github.com/E3SM-Project/E3SM/issues/6188

 34: forrtl: severe (194): Run-Time Check Failure. The variable 'ecosystembalancecheckmod_mp_colpbalancecheck_$NSTEP' is being used in '/global/cfs/cdirs/e3sm/ndk/repos/me37-jan23/components/elm/src/biogeochem/EcosystemBalanceCheckMod.F90(742,21)' without be\
ing defined
 34: Image              PC                Routine            Line        Source
 34: e3sm.exe           00000000009D842D  elm_driver_mp_elm        1347  elm_driver.F90
 34: e3sm.exe           0000000000956157  lnd_comp_mct_mp_l         617  lnd_comp_mct.F90
 34: e3sm.exe           00000000004A8323  component_mod_mp_         757  component_mod.F90
 34: e3sm.exe           000000000046955B  cime_comp_mod_mp_        2915  cime_comp_mod.F90
 34: e3sm.exe           0000000000490BCB  MAIN__                    153  cime_driver.F90
 34: e3sm.exe           000000000043336D  Unknown               Unknown  Unknown
 34: libc-2.31.so       0000148C5943C24D  __libc_start_main     Unknown  Unknown
 34: e3sm.exe           000000000043329A  Unknown               Unknown  Unknown