Andy Lester

icon indicating a website link http://petdance.com/ icon indicating an email [email protected]

icon location Palatine, IL icon location I wrote ack (@beyondgrep). I'm shepherding Perl::Critic (@Perl-Critic). I do other Perl stuff.

Results 496 comments of Andy Lester

Replace XML::Easy by a more recent module?

> > I would too, however keep in mind that the JSON that Solr expects allows for repeated keys (e.g. "add"), Well so much for that idea. Thanks for the...

Replace XML::Easy by a more recent module?

Just on a basic survey of CPAN, I'm thinking XML::Writer might be the way to go. I like the idea of write-only.

ProhibitMatchVars doesn't detect match vars inside interpolated strings

I suspect this is a PPI issue over a Perl::Critic issue, but I haven't looked.

ProhibitUselessTopic should not complain about the left side of a fat comma

See also #976, #830, #829, #708, #600.

regex: suggest reusing same pattern

Thanks for the idea. I forgot about how Perl had those shortcuts. In this case, I don't see why you would check before replacing. This is functionally identical to if...

regex: suggest reusing same pattern

OK, that's interesting. You don't want to figure out the replacement unless you need to. Hmmm. The whole thing just feels fragile and easy to mess up. I'm not sure...

regex: suggest reusing same pattern

Here's a weird little coincidence. Perl 5.38.0 now lets you get at that last successful match. https://metacpan.org/release/RJBS/perl-5.38.0/view/pod/perldelta.pod # New regexp variable ${^LAST_SUCCESSFUL_PATTERN} This allows access to the last succesful pattern...

RequireCheckingReturnValueOfEval still needed?

What bug reports do you refer to? Is it that the policy doesn't work, or that people don't like the policy?

RequireCheckingReturnValueOfEval still needed?

I can't see getting rid of the policy. Not sure what "recent" means as far as making it safer to check $@, but unless it's been around for a long...

ProhibitEmptyQuotes should be configurable

I'm not understanding what you're suggesting. What is an example of code that trips this warning that you would like to be able to configure past?