Andy Lester comments

Results 496 comments of


                                            Andy Lester

perlcritic.com domain expired

Can this be closed now?

Add specific shell types

Although now that I think of it, this might cause problems. If I say `--bash` and my bash files are *.sh, despite the shebang, will they get missed?

Docs say to mail to "[email protected]" for submitting policy modules

Also remove the stuff that talks about hiring the Perl::Critic team.

Add terminals parameter to ProhibitUnreachableCode.

I'm confused. `done_testing` doesn't actually stop execution of the program.

Add terminals parameter to ProhibitUnreachableCode.

I was under the impression that `done_testing()` is just a notice to the harness to stop counting tests. Are you saying it affects program flow, too?

Add terminals parameter to ProhibitUnreachableCode.

And maybe `terminals` isn't the term to use, then?

Add terminals parameter to ProhibitUnreachableCode.

The behavior of done_testing doesn't relate to whether this is a good patch or not. I just don't think we want to use it as an example, since it doesn't...

Add terminals parameter to ProhibitUnreachableCode.

So is there no longer a use case for this?

Policy::Modules::RequireVersionVar: only modules and libraries should be tested

We can do this if we make it a flag, where it can be configured to not require a `$VERSION` in programs.

RFE: Move Dockerfile to project top level

Please tell more about this. I added the Dockerfile because someone suggested it, but I put it in extras so it was clear that it wasn't something that we were...