Andy Lester comments

Results 496 comments of


                                            Andy Lester

Proof-of-concept for emitting JSON for GitLab code quality reports

Sorry I haven't looked at this until now. It looks like a pretty simple idea. My big concern with adding this is that it adds another dependency to P::C. OTOH,...

Add jinja2 filetype

They seem to recommend .jinja as extension. https://jinja.palletsprojects.com/en/3.0.x/templates/#template-file-extension

RequireEndWithOne shouldn't trigger on use v5.38 and above

Based on reading the [perldelta](https://perldoc.perl.org/5.38.0/perldelta#Updated-Modules-and-Pragmata), this needs to be more than just a version check. It should check for one of: * `use v5.38` or higher * `use feature "module_true"`...

Strange behaviour when search string begins with + character

> because of the way the code calls that module I wasn't successful in creating a patch. Do you have any tests written that would save me from writing them?

Strange behaviour when search string begins with + character

> I haven't written tests , no I was asking @epa who sounded like he had been working on code.

Suggested policy: replace if-else with //

We'd also want to get the ternary version: ``` $v = defined($something) ? $something : $default; ``` Probably would also want to detect: ``` if ( !defined($x) ) { $x...

Suggested policy: replace if-else with //

Especially now that we only run on 5.10.1 and up.

add B<--nolinenumber>

Note: There will always be Perl tests. The YAMLization is just for making the tests more flexible.

Replace XML::Easy by a more recent module?

I have no objection to changing it to something else. My only concern is that I wouldn't want something that brought in a ton of dependencies.

Replace XML::Easy by a more recent module?

I also wouldn't mind having communication with the server being in JSON instead of XML.