Aurélien Perrier

Results 13 comments of Aurélien Perrier

> can I entrust you with completing this task? Yes, but, I need to explore how add `protovalidate` in the core and if it's complicated or not : - PGV...

Finaly, It's simple (after one call HTTP) : ``` 2023-11-13T23:57:00.408+0100 [ERROR] app: args="filters:{values:\"1\"} sort:{argument:Ticker} pagination:{items:1 page:-1}" caller=recovery/recovery.go:59 code=400 component=http kind=server latency=0.001073208 operation=/instruments.v1.Instruments/Search reason=VALIDATOR stack= | error: code = 400 reason...

> Hi, @perriea, > > I'm helping the Kratos team manage our backlog and am marking this issue as stale. From what I understand, you requested replacing `PGV` with `protovalidate`...

@mecmus, @njuettner or @seanmalloy can you review again ?

@tonybase @shenqidebaozi #2541 fix the problem right ? Often the http scope is not covered

@shenqidebaozi we have everything, but I don't know how to test validation with this new format. If you have an idea... https://github.com/go-kratos/kratos/pull/3084/files#diff-ab47f4f86064e3934ea13b3f4611a2a223f0655e51afbeea00b989d25ecadc75R32

@shenqidebaozi Let me remind you, any opinion ?

> Any update for this PR? This change is important, but I have no answer... Sorry