kratos icon indicating copy to clipboard operation
kratos copied to clipboard

feat(middleware/validate): replace PGV by protovalidate-go

Open perriea opened this issue 1 year ago • 3 comments

Description (what this PR does / why we need it):

  • [x] Replace PGV by protovalidate-go on validate package,
  • [x] Remove PGV on kratos cli

Which issue(s) this PR fixes (resolves / be part of):

#3081

WARNING It's a breaking change !

perriea avatar Nov 13 '23 22:11 perriea

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c7fa51d) 84.62% compared to head (e90f165) 84.11%.

:exclamation: Current head e90f165 differs from pull request most recent head 1ff90bb. Consider uploading reports for the commit 1ff90bb to get more accurate results

Files Patch % Lines
middleware/validate/validate.go 28.57% 4 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   84.62%   84.11%   -0.52%     
==========================================
  Files          88       88              
  Lines        3993     3997       +4     
==========================================
- Hits         3379     3362      -17     
- Misses        440      457      +17     
- Partials      174      178       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 20 '23 16:11 codecov-commenter

@shenqidebaozi we have everything, but I don't know how to test validation with this new format. If you have an idea... https://github.com/go-kratos/kratos/pull/3084/files#diff-ab47f4f86064e3934ea13b3f4611a2a223f0655e51afbeea00b989d25ecadc75R32

perriea avatar Nov 20 '23 18:11 perriea

@shenqidebaozi Let me remind you, any opinion ?

perriea avatar Jan 02 '24 01:01 perriea

Any update for this PR?

IfanTsai avatar Mar 05 '24 08:03 IfanTsai

Any update for this PR?

This change is important, but I have no answer... Sorry

perriea avatar Mar 05 '24 09:03 perriea

Please fix the issue of github action line failure first

shenqidebaozi avatar Mar 05 '24 11:03 shenqidebaozi

Also, should we treat PGV as some kind of implementation, with the standard interface in validate

shenqidebaozi avatar Mar 05 '24 11:03 shenqidebaozi

Please fix the issue of github action line failure first

We have a problem on the CI, I have an error unrelated to my modifications (contrib)...

perriea avatar Mar 05 '24 12:03 perriea

Your code changes contain many contrib changes. You may consider resubmitting a PR or abandoning other changes and only modifying PGV

shenqidebaozi avatar Mar 06 '24 03:03 shenqidebaozi

@perriea I see that this PR has been closed. Is there any problem?

shenqidebaozi avatar Mar 22 '24 03:03 shenqidebaozi

The current PR only needs to remove additional modifications. Also, can the validate interface be retained and PGV be used as a new implementation. What do you think?

shenqidebaozi avatar Mar 22 '24 03:03 shenqidebaozi

@perriea I see that this PR has been closed. Is there any problem?

One of my colleagues accidentally deleted my fork... this action closed my PR...

perriea avatar Mar 25 '24 14:03 perriea