percivalalb
percivalalb
I have to agree, the 16 missing cards were Club 2, 8, 10, J, Q Diamond 6, 8, 9, K Hearts 2, 5 Spades 6, 7, 9, 10, J
I think I'm also experiencing the same on v2.1, running the codegen a dozen times produces 2 or 3 distinct diffs. In each case the base64 data in `var swaggerSpec...
The spec in https://github.com/percivalalb/oapi-codegen-issue-1572 reproduces this issue
> Thanks so much @percivalalb 🙌 > > Via [our very new contribution guideline](https://github.com/deepmap/oapi-codegen/blob/master/CONTRIBUTING.md#minimal-reproductions), mind also sticking an Apache-2..0 license on that repo? Sure - done
The issue stems [from `InternalizeRefs` call](https://github.com/deepmap/oapi-codegen/blob/da9077bb5ffecff9185dc13d23760580d899333d/pkg/codegen/inline.go#L31C10-L31C25) not being particular clever about the names it gives the new schemas/components it adds. The [default behaviour](https://github.com/getkin/kin-openapi/blob/2ab0c0e0ff1cd1ca72537dbddf2bebebd32d827e/openapi3/internalize_refs.go#L11) is: > // If a reference points...
The changes needed to the kin-openapi library are present in v0.126.0, I'll wait for https://github.com/oapi-codegen/oapi-codegen/pull/1689 to be merged before completing this PR
This is now ready for review
> Hello! > > How about a func that, given a `doc` and a `Schema`, returns a `*SchemaRef` (a ptr under `doc`) or `nil`? Would this not cover your use...
I've moved the alternations out of the code gen'ed files, sorry I'm still getting familar with the project setup and just thrown everything in the helper file. I'd like to...
Things to do: - I think these snippets https://github.com/getkin/kin-openapi/pull/945/files#diff-035b395ae81006bbe6cd7144c686238113762fccdb051ddaef5d507560039ee6R540 which construct the refPath should be moved to a single function in `resolveComponent`. I believe componentPath should be the value we...