Dean Herbert

Results 1958 comments of Dean Herbert

if you're already tested with lazer as to how it will work, then you could consider it. also consider that if it doesn't work in stable, it will likely be...

Is this good to go? There's still some checkboxes in the OP which suggest there's more work to be done, but we also have review and approval from walavouchey soo

This looks like it will work well for the scenario in question. I'd want a second @ppy/team-client review as this is a framework change altering a central component.

@EYHN Based on the above, and the general feeling that we don't want to over-complicate the `SliderBar` class, we should try and figure a local workaround for this osu! side...

I can agree that it's not great, but do you have a better suggestion for it?

First, please explain why this matters. From what I gather, you're saying "the time should be set at the start of the frame, not the end". But frames are updated...

Where is the "lag" coming from in this image?

For the GC pause case, I believe it has just as high a chance of running before the time update to after, so isn't a valid consideration. For pump events...