Robert Pająk

Results 821 comments of Robert Pająk

The lack of stabilization of `Logger.Enabled` API blocks stabilization of OTel Go Logs. `Logger.Enabled` API is required for bridging most popular Go logging libraries (including `slog` from the Go standard...

2025-04-23 SIG meeting notes: There is a proposal to add this parameter to the specification. However, it would be good to have a use case for it.

@open-telemetry/technical-committee, are you able to revalidate if the issues listed as blockers are still seen as blockers or if they can be addressed after stabilization of Logger.Enabled in Logs Bridge...

@cijothomas, is adding `EventName` parameter to `Enabled` still important for C++ and Rust (given `EventName` is a `string`)? We could add this for Go. Yet, we have not heard of...

OK. See we need 3 different languages to have it released as experimental API. Here is how the experimental Logger.Enabled API is currently defined in a 3 languages: - C++:...

I created a PR: - https://github.com/open-telemetry/opentelemetry-specification/pull/4489

@jack-berg, I have question on what is required regarding the SDK implementation specification/design to unblock the stabilization of `Logger.Enabled` API. 1. Is an OTEP like this good enough: https://github.com/open-telemetry/opentelemetry-specification/pull/4290? 2....

I also want to call out that we already have 4 working prototypes of `Logger.Enabled`: - [OpenTelemetry C++](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/logs/logger.h) - [OpenTelemetry Go](https://github.com/open-telemetry/opentelemetry-go/blob/main/log/logger.go) - [OpenTelemetry PHP](https://github.com/open-telemetry/opentelemetry-php/blob/main/src/API/Logs/LoggerInterface.php) - [OpenTelemetry Rust](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/logs/logger.rs) They have slight...

> in particular, think that adding `LoggerConfig#min_severity` and `LoggerConfig#trace_based` properties are no brainers. I wonder if anyone would disagree? I do not see them as no brainers. I am personally...

According to spec compliance matrix it is implemented in 3 languages: https://github.com/open-telemetry/opentelemetry-specification/blob/d2035751f3fc89a1ef44eb883dac63facc913138/spec-compliance-matrix.md?plain=1#L202 I saw that `Logger.Enabled` is also added to PHP (which gives 4 languages): https://github.com/open-telemetry/opentelemetry-php/blob/015da800aa005d69f1b54a54c28af9173e236c7f/src/API/Logs/LoggerInterface.php#L15-L20 @open-telemetry/technical-committee, are there any...