Robert Pająk

Results 812 comments of Robert Pająk

`Emit` does not accept "options" (meaning options pattern) as this would decrease the performance of calls that would use these options. References: - https://github.com/open-telemetry/opentelemetry-go/blob/main/log/DESIGN.md#options-as-parameter-to-loggeremit - https://github.com/open-telemetry/opentelemetry-go/blob/main/log/DESIGN.md#loggeremit If needed we can...

> Planning to close in about a week if there would be no response. Closing after a month

This PR seems improperly synced with `main`.

@xue20xi, given the latest comment I think we can close the PR. Do you want to work on fixing https://github.com/open-telemetry/opentelemetry-go/issues/6661 given it seems to be a bug and you already...

Looks like we need to add some `//nolint` comments or rename packages if they are internal:: ``` golangci-lint ./schema Error: schema/v1.0/types/types.go:5:9: var-naming: avoid meaningless package names (revive) package types //...

Hi, currently I have no time to review this PR, but I just want to call out that use of `weak` would not "improve" the performance (on the hot-path). It...

How about changing the `Enabled` to accept a simple struct named e.g. `EnabledParams` with getters and setters (in order to avoid heap allocations)? The getters should also return a bool...

> A different pattern that avoids allocations is to have a struct "Settings/Config" instead [...] This seems acceptable to me (as noted in https://github.com/open-telemetry/opentelemetry-go/pull/5770#issuecomment-2327444064). EDIT: At minimum, we need to...

> This was removed from the specification based on the feedback of the spec SIG during a meeting: https://github.com/open-telemetry/opentelemetry-specification/commit/19ade6db74d62bd139f3e81f8497342f2da393c4 @MrAlias, do you know the reason why the following was removed:...

> This was removed from the specification based on the feedback of the spec SIG during a meeting: https://github.com/open-telemetry/opentelemetry-specification/commit/19ade6db74d62bd139f3e81f8497342f2da393c4 From my understanding it was removed mostly because @jack-berg just wanted...