Pedro Impulcetto comments

Results 14 comments of


                                            Pedro Impulcetto

fix: using the right type for Any paramenter

Can you check, please @asacristani ?

fixed trunk issues in conftest

Hey @abdurrehman11 thanks for colaborate! First of all, if your PR is not done to be merged, please keep it in Draft to avoid any issues.

feat: including typehints; tox to manage packages; mypy to static check; remove unnecessary requirements; change circle ci to use tox; run black and isort to format

> Hey @pedroimpulcetto, thank you for your contribution. I'm excited to see our client getting improvements! > > I've left a few comments on things I noticed right away, however...

Roadmap

Hey @abdhx , here you can check more context about the migration https://github.com/Kludex/starlette/discussions/2997

add support to dynamic url docs based on the FastAPI docs_url param

hey @svlandeg, as we are stuck with the other PR, I just made the changes to fix #162

add support to dynamic url docs based on the FastAPI docs_url param

hey @tiangolo I would love to have it merged and fix #162 issue 🙏 let me know your thoughts

add support to dynamic url docs based on the FastAPI docs_url param

hey @patrick91 @tiangolo, what are your thoughts about it? we would love to get it in

Hard-coded documentation endpoint

hey everyone, I'm just fixing this with PR #221

Hard-coded documentation endpoint

@FlavienRx thanks for looking into this Just let me know if you have any improvement, request change or anything else for my PR #221 I will be happy to adjust...

We may need to make some small changes from the `Optional` type to use `NotRequired`. - Take a look at the [Typed Dict reference](https://docs.python.org/3/library/typing.html#typing.TypedDict) And also, it would be nice...