fastapi-cli icon indicating copy to clipboard operation
fastapi-cli copied to clipboard
verified publisher icon tiangolo

Hard-coded documentation endpoint

Open twibster opened this issue 10 months ago • 4 comments

Using the CLI to start the application, whether in dev or prod mode, would show hardcoded, aka incorrect/misleading documentation endpoint

The part responsible for this is here, which is clearly hard-coded: https://github.com/fastapi/fastapi-cli/blob/9a4741816dc288bbd931e693166117d98ee14dea/src/fastapi_cli/cli.py#L137

There is a PR already that addresses this issue: https://github.com/fastapi/fastapi-cli/pull/24#issue-2293513757

twibster avatar Mar 04 '25 03:03 twibster

hey everyone, I'm just fixing this with PR #221

pedroimpulcetto avatar Oct 05 '25 09:10 pedroimpulcetto

Hey everyone! 👋

There are 3 PR about this issue: #24 (opened 13/05/2024) #119 (opened 09/11/2024) #221 (opened 02/10/2025)

Could someone help pick the best approach, review it, and suggest any tweaks before we finalize the best PR?

We’d be happy to adjust it and get this merged! 🚀

@tiangolo @YuriiMotov

FlavienRx avatar Nov 06 '25 08:11 FlavienRx

@FlavienRx thanks for looking into this Just let me know if you have any improvement, request change or anything else for my PR #221 I will be happy to adjust it

pedroimpulcetto avatar Nov 08 '25 05:11 pedroimpulcetto

Hi everyone! 👋

I'd like to help move this issue forward by thoroughly testing and reviewing PR #221.

I'll be:

  • Testing the fix with different docs_url configurations
  • Verifying the behavior with docs_url=None
  • Running the existing test suite
  • Providing detailed feedback on the implementation

I'll share my findings once testing is complete. 🚀

themojtabajaveed avatar Nov 19 '25 07:11 themojtabajaveed