Shohei Ueda

Results 149 comments of Shohei Ueda

I don't fully understand the background of your issue, but this issue seems to be a duplicate of #163 > implementing it using a shell script but the deploy key...

Thank you for creating #279. I understood your proposal by the Pull Request. I'm going to look at this proposal in a positive way and add test cases. In the...

## About the failure > I am using the latest version of this action. I am very happy to check and follow this before opening an issue. Could you use...

I have not known what is better in Flutter land, so I have followed [the official instruction](https://flutter.dev/docs/get-started/install/linux). The `git clone` approach looks faster for me than that action. - git...

Thank you for suggesting this. Yes. I sometimes think the log of `git rm` is long, me too. I plan to show the log when the debugging flag is enabled...

Thank you for the suggestion. Good idea. I'm assuming usage like the following. ```yaml - name: Deploy uses: peaceiris/actions-gh-pages@v3 with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./public dry_run: ${{ github.event_name ==...

Could you test #513 as follows? ```yaml - name: Deploy uses: peaceiris/actions-gh-pages@41f7401 #513 with: github_token: ${{ secrets.GITHUB_TOKEN }} dry_run: ${{ github.event_name == 'pull_request' }} ```

Only when we set `publish_dir: .`, this action deletes `.git` directory. This is my corner‐cutting and will be improved on the next release.

Thank you for suggesting this! Yes. That looks useful. A longer option name may be easier to understand as follows. ```js core.setOutput('pages_commit_hash', sha); ``` I also considered the following output...

Cool! We already have `${{ github.sha }}` in the GitHub Actions contexts. (src_sha) The GitHub Actions context uses `github.sha` so we will choose `dst_sha`. (destination) Thanks @sidvishnoi