Shohei Ueda
Shohei Ueda
> Feedback for this issue form, while I understand "Relevant links" would be useful for troubleshooting, it seems unnecessary for "Relevant log output" and especially "Additional context" fields to be...
[The milestone of v3.9.0](https://github.com/peaceiris/actions-gh-pages/milestone/2) has been created.
Thank you for the suggestion!
Since I have no environment of GitHub Enterprise Server, I was looking forward to this issue, thanks! https://github.com/peaceiris/actions-gh-pages/blob/a0db9b66be08f409f8263ee57ca1dd625d9f0b59/src/set-tokens.ts#L66 We can modify the function `setGithubToken` to get a server domain from...
- https://github.com/actions/checkout/blob/25a956c84d5dd820d28caab9f86b8d183aeeff3d/src/url-helper.ts#L22 - https://github.com/actions/checkout/blob/25a956c84d5dd820d28caab9f86b8d183aeeff3d/src/git-auth-helper.ts#L54 Those are also helpful for us. ```ts export function getServerUrl(): URL { // todo: remove GITHUB_URL after support for GHES Alpha is no longer needed return...
The former is the best because `GITHUB_SERVER_URL` can provide a URL of a company's GitHub Enterprise Server.
We can test #580 with 3623583f73a5cfb5ca3632d6234b9564fed73239 ```yaml - name: Deploy uses: peaceiris/actions-gh-pages@3623583f73a5cfb5ca3632d6234b9564fed73239 with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./public ```
`github_token` and `personal_token` look good to me, it also works well on github.com. I will work on SSH implementation on #581
@dominikmeyersap Could you try `v3.8.0`? The release `v3.8.0` has capability of deployment with `github_token` and `personal_token`, excluding `deploy_key`. The SSH option for GitHub Enterprise will be implemented in the next...
We can learn a lot from [nwtgck/actions-netlify](https://github.com/nwtgck/actions-netlify). This looks worth thinking about. Thank you for the suggestion!