Philip Deljanov

Results 69 comments of Philip Deljanov

Hi @mooman219, I probably should've read this before looking at your first PR. I don't have any experience writing a no_std library so unfortunately I can't offer any solid advice...

Hi @mooman219, Apologies for being inactive on this. Unfortunately, I don't think I'll be able to help much on this until after I release v0.5. There are a number of...

Hi @vatosarmat, You're right. There is no good way of knowing right now given the current API. I'll see what I can do to resolve this for v0.5.

I didn't try them all, but for all the MP3 files I tried, the issue seems to be within the ID3v2 parser being too strict. It's encountering a tag with...

The broken MP3s should be fixed with the last two commits.

Regarding the wave files: - `sample.wav` and `idw_testsound.wav` are ADPCM Wave files and are unsupported currently. #41 tracks ADPCM support. - `jetpack1.wav` is technically an invalid encoding, but Symphonia should...

Hi @izissise, I may consider implementing a limited set of muxers in the long-long-term, but I don't see myself writing any encoders. However, I'd be happy to accept contributions for...

Hi @Herschel, Sorry for the late response. Yes, in retrospect I do feel like this was not the best change to make. I think I will probably be reverting this...

Hey @GeoffClements, I think there are two ways Symphonia could be made async: 1. Change `MediaSourceStream` to be async and update all `FormatReaders` and `MetadataReaders` to be async as well....

Hi @GeoffClements and @vishalcjha, I took a look at what's already implemented and wanted to chime in with a few of my thoughts. The first thing that sticks out to...