Philip Deljanov

Results 69 comments of Philip Deljanov

Hi @aschey, Yes, using the hint to prioritize certain readers would be a good and quick solution for the time being, though it wouldn't be robust in cases such when...

Hi @aschey, Sure, I'll gladly accept a PR. Since the scoring process will add overhead to format detection, being able to prioritize readers based on the hint will be very...

Hey @rtyler, You're not mistaken. Chapters are an [extension](https://id3.org/id3v2-chapters-1.0) to the original ID3v2 standards, and they haven't been implemented yet. This is something we'll want to support, but it may...

Hi @SeanOMik, sorry, this hasn't been fixed yet. It's a bit tedious to fix so it's been low priority. I'll probably loop back around to it after v0.5 is published.

Hi @mooman219, Thanks for taking on this task. I'm sure there will be many people who appreciate this work! Is there a way to do this conversion without having to...

Hey @mooman219, Thanks! This looks a fairly straightforward and clear change. Thanks for that tip as well, very clever! I missed your last reply to the issue you raised for...

I gave these a quick run-through, and it appears that the overwhelming majority of the issues are the same as last time. I'll have to take a closer look at...

Hi @Azorlogh, In regards to the first part, that's a good idea. Unfortunately, for MP3 the only way to do an accurate seek is by scanning the file/stream. A fast...

Hey @thinking-tower, I'm not particularly familiar with range decoding so I can't comment on the correctness of the code/give a proper review. Do you think it'd be a good idea...

Hi @fengalin, This would be a nice improvement to `RawSampleBuffer` since it does save a copy. I also see this being useful for `SampleBuffer` since it suffers from the same...