Willem Melching

Oops. Did not see: https://github.com/dinoboff/github-tools/issues/14 Maybe this should be added to the documentation.

Without logging the key something like process replay wouldn’t work on SecOC routes. It will use the key to verify messages from the car, and throw an alert/not engage if...

Same issue as https://github.com/commaai/panda/pull/1204 ?

Looks like after https://github.com/commaai/panda/commit/c66b98b2a67441faa4cfcd36c3c9d9f90474cd08 it works again. Seems like touching these UART FIFOs has the tendency to break/fix the code on newer compilers. See https://github.com/commaai/panda/pull/1204 Tested with `arm-none-eabi-gcc (Arch Repository)...

We should probably have a python script that checks for overlap in CI. I would definitely merge that PR. See https://github.com/commaai/opendbc/blob/master/can/process_dbc.py for parsing.

https://github.com/socketcan-rs/socketcan-rs/pull/58/files

Rough ToDo list: - [x] Gate everything behind a feature (and windows). - [x] Add vxlapi.dll (64 bit version only?) and vxlapi.h to `third_party/vector`. - [ ] Probably best to...

This will do for now. Passes stress tests, and works with internal crates. Bitrate settings will be pulled from the original PR when other adapters get support for changing settings...

I have seen your crate and appreciate the work! I'm not sure if it makes sense to rely on an external dependency for this due to how rust packaging works....

I'll check what changes would be needed and consider it. Most likely I wont have time till after Black Hat & Defcon. Two things I'm missing after a quick glance...