Willem Melching
Willem Melching
Making the dialog wider and shorter is fine with me. Alternatively you can figure out how to rotate the map to make it fit, but that might look confusing if...
I was working on this a bit as well, and represented the values as an `std::vector val` in opendbc. This should make working with the values later much easier.
Hmm, must have missed something when rebasing my changes on latest master. Where do you need to check for sig not being a nullptr?
What do you think of storing the description as a list of key value pairs? That allows us to show the correct description in the signal widget, and implement a...
@deanlee any ideas on how to cleanly set the edited/new signal to be the new `hovered_sig`?
How do I get a pointer to the new signal? Or does the old pointer stay valid?
Ah great that this is possible after all. I looked in the docs but couldn't find it.
Those are already supported! Just plug it in and select from the startup dialog.
Tested build on Linux, MacOS and C3. @adeebshihadeh This is ready for review. I assume the failing CI is due to the changes in `install_ubuntu_dependencies.h` and will be fixed after...
@deanlee Any thoughts on how to decouple this from the `fps` setting? `SignalView::updateState` is only called at the rate of the fps. Ideally I'd like to react to CAN messages...