panda icon indicating copy to clipboard operation
panda copied to clipboard

Compiling with newer versions of GCC results in broken firmware

Open robbederks opened this issue 1 year ago • 8 comments

The application firmware image compiled with arm-none-eabi-gcc version 10.3 instead of 9.3.1 (default in ubuntu 20.04) does not boot on white pandas (have not tested others). Bootstub seems fine.

robbederks avatar Apr 11 '23 23:04 robbederks

Same issue as https://github.com/commaai/panda/pull/1204 ?

pd0wm avatar Apr 13 '23 09:04 pd0wm

I am seeing the same, but the buffer size is already set to the smaller one.

olesalscheider avatar Apr 25 '23 12:04 olesalscheider

The application firmware image compiled with arm-none-eabi-gcc version 10.3 instead of 9.3.1 (default in ubuntu 20.04) does not boot on white pandas (have not tested others). Bootstub seems fine.

Tried with grey panda and had similar or same problem. Just seems to be completly dead.

danielzmod avatar Apr 29 '23 14:04 danielzmod

Looks like after https://github.com/commaai/panda/commit/c66b98b2a67441faa4cfcd36c3c9d9f90474cd08 it works again. Seems like touching these UART FIFOs has the tendency to break/fix the code on newer compilers. See https://github.com/commaai/panda/pull/1204

Tested with arm-none-eabi-gcc (Arch Repository) 13.2.0

pd0wm avatar Aug 22 '23 13:08 pd0wm

Still want to look into the root cause at some point to prevent this issue from happening again, so will keep this open for now.

robbederks avatar Aug 22 '23 13:08 robbederks

Once we investigate and fix properly, we’ll also add a latest GCC build to CI.

adeebshihadeh avatar Aug 22 '23 14:08 adeebshihadeh

@pd0wm reported that #1559 fixed the issue. Should we close it or still want to investigate the cause?

briskspirit avatar Aug 23 '23 18:08 briskspirit

No, we definitely still need to look into this.

adeebshihadeh avatar Aug 23 '23 18:08 adeebshihadeh