openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard
verified publisher icon commaai

cabana: add keyboard shortcuts to binary view

Open pd0wm opened this issue 2 years ago • 4 comments

  • Delete signal: x, backspace, delete
  • Toggle endianness: e
  • Toggle signedness: s
  • Open chart: c, p, g (Chart, Plot, Graph)

Any thoughts on how to explain this to the user?

pd0wm avatar Feb 14 '23 15:02 pd0wm

@deanlee any ideas on how to cleanly set the edited/new signal to be the new hovered_sig?

pd0wm avatar Feb 14 '23 15:02 pd0wm

call BinaryView::highlight(signal) or emit highlight(sig) in SignalView. Do these two methods meet your needs?

deanlee avatar Feb 14 '23 16:02 deanlee

How do I get a pointer to the new signal? Or does the old pointer stay valid?

pd0wm avatar Feb 14 '23 17:02 pd0wm

the old pointer stay valid after updated, signal address will not changed after call DBCManager::updateSignal

deanlee avatar Feb 14 '23 17:02 deanlee

Any thoughts on how to explain this to the user?

added an online-help: https://github.com/commaai/openpilot/pull/27349 .

deanlee avatar Feb 15 '23 05:02 deanlee