Pavlos Chrysochoidis

Results 33 comments of Pavlos Chrysochoidis

Dapp part is fixed. Also pushed the changed to s3 -> http://sui-wallet-demo.s3-website-us-east-1.amazonaws.com/

> Could we please move and align the connected pill to the center of the nav bar? > > ☝🏼 As you can see it is not center aligned. This...

> ⚠️ 🦋 **Changesets Warning:** This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running `pnpm changeset`, and...

> One edge case we should handle in the wallet is when user wants to transfer all their SUI to another address(and use part of it to pay for the...

Thanks @Jordan-Mysten, I think I addressed all the comments. Let me know if there is anything else!

`getOwnedObjectRefs` was replaced by `getObjectsOwnedByAddress` [here](https://github.com/MystenLabs/sui/commit/86835c1ad58182b13895331e0b073e2b5fa0a350#diff-2ebd02d268992461bd0de339491d7d20fb5fec90a8f861b21a081ffb596d4922R19) Using [getObjectRef](https://github.com/MystenLabs/sui/blob/main/sdk/typescript/src/providers/provider.ts#L207) is not correct here since the example is about fetching objects owned by an address and `getObjectRef` fetches the reference of an...

@mystie711 * Logo position should be a bit better now after merging https://github.com/MystenLabs/sui/pull/7902 (there is a small difference still but we need to replace the logo font icon with an...

> Great progress @pchrysochoidis! Just a few more items, > > * The "

> Awesome! Could the "spinner" show inside the (SAVE) button pill...effectively replacing the SAVE text while it is in progress? This should probably be a part of the button component...

@mystie711 Done https://user-images.githubusercontent.com/10210143/218798356-24cbe794-3262-429a-9c52-e53166516915.mov