sui icon indicating copy to clipboard operation
sui copied to clipboard

Update README.md

Open sandrogomes94 opened this issue 2 years ago • 4 comments

update method used in examples

sandrogomes94 avatar Feb 06 '23 19:02 sandrogomes94

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 7:51PM (UTC)
frenemies ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 7:51PM (UTC)
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 7:51PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
explorer-storybook ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:51PM (UTC)

vercel[bot] avatar Feb 06 '23 19:02 vercel[bot]

the getOwnedObjectRefs method does not exist in the JsonRpcProvider class, i changed it to the correct method getObjectRef

ghost avatar Feb 09 '23 04:02 ghost

the getOwnedObjectRefs method does not exist in the JsonRpcProvider class, i changed it to the correct method getObjectRef

Thank you!

randall-Mysten avatar Feb 09 '23 16:02 randall-Mysten

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

github-actions[bot] avatar Feb 09 '23 16:02 github-actions[bot]

getOwnedObjectRefs was replaced by getObjectsOwnedByAddress here

Using getObjectRef is not correct here since the example is about fetching objects owned by an address and getObjectRef fetches the reference of an object.

It seems though readme already has been updated on main.

cc @kchalkias

pchrysochoidis avatar Mar 03 '23 14:03 pchrysochoidis

pchrysochoidis is right, i think that can close this request

ghost avatar Mar 03 '23 21:03 ghost