Philippe Canal

Results 332 comments of Philippe Canal

> So the debate is, do we want 2 flags for turning off vs 2 flags for turning on. An important side note is that the proposed behavior will (likely)...

I agree that the current situation is broken (need the change in row 3) but I still think it can be achieved while not making the change in row 2.

> Why you don't think that the proposed behavior is better, besides backwards compatibility concerns? Because it unnecessarily (as far I can tell) breaks backward compatibility (and the proposed code...

> In my opinion, if keeping backward compatibility can be done with let's say 20 lines of extra total CMake code (I am not sure how to do that) It...

> but still builtin_fftw3=ON implies fftw3=ON I don't think that is a problem. The 'only' problem I see is that the current code does the wrong thing in that it...

It is confirms that one of those files: ``` -rw-r--r--. 1 pcanal us_cms 8962 Oct 19 17:56 ./tmva/pymva/test/PyTorchModelSequential.pt -rw-r--r--. 1 pcanal us_cms 11913 Oct 19 17:56 ./runtutorials/modelClassification.pt -rw-r--r--. 1 pcanal...

However `gtest-tmva-pymva-TestRModelParserKeras` fails without or without those files.

Apparently it is the test itself that is not runnable a second time :(:( ``` jupyter-pcanal-rootdevel:quick-devel pcanal$ ctest -R gtest-tmva-pymva-TestRModelParserPyTorch Test project /home/pcanal/root_working/build/quick-devel Start 349: gtest-tmva-pymva-TestRModelParserPyTorch 1/1 Test #349: gtest-tmva-pymva-TestRModelParserPyTorch...

The summary is simple (and still the same after applying [`38b0d88` (#16722)](https://github.com/root-project/root/pull/16722/commits/38b0d88d1d51fe914a6aff3645f03a483e31588a): On first run in a clean directory with `BLAS` missing, we get: ``` ctest -R gtest-tmva-pymva-TestRModelParserPyTorch Test project...